Fix clang build problem in AdaptiveVertexFitter

[Dr15Jones]

clang does not permit a variable sized array to be passed to a lambda.
So instead we pass a pointer to the first element of the array. An
optimizing compiler should make the two implementations into the same
machine code.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Fix clang build problem in AdaptiveVertexFitter

It involves the following packages:

RecoVertex/AdaptiveVertexFit

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @makortel, @acaudron, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @ferencek, @cerati, @pvmulder, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[davidlt]

The package compiles fine under pre-3.6 Clang in DEVEL IB. A number of failing packages in CLANG IB are fine with new Clang IIRC.

[Dr15Jones]

Great, but I'm afraid we need the clang build to be clean now so that the static analyzer report is complete.

[cmsbuild]

-1
Tested at: 9c51948
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7195/1906/summary.html

[Dr15Jones]

The test failures are unrelated to this pull request.

[cmsbuild]

+1
Tested at: 9c51948
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7195/1925/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7195/1925/summary.html

[slava77]

+1

for #7195 9c51948
looks ok, and runs/clean in jenkins

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.