Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce fit errors in HCal local reco to a summary #7205

Merged
merged 2 commits into from Jan 16, 2015

Conversation

mark-grimes
Copy link

Running HCal local reconstruction results in thousands of fit errors at 140 pileup. Whilst the cause of this is investigated, this pull request suppresses each individual message and instead outputs a message once per event detailing how many times each error occurred.

So instead of ~16k occurrences of e.g.

%MSG-w HybridMinimizer:  HcalSimpleReconstructor:hbheUpgradeReco  16-Jan-2015 03:08:37 CET Run: 1 Event: 2002
HybridMinimizer::Minimize : Minimization did NOT converge, Edm is above max
%MSG

There is now one occurrence of

%MSG-w HcalSimpleReconstructor:  HcalSimpleReconstructor:hbheUpgradeReco  16-Jan-2015 03:08:37 CET Run: 1 Event: 2002
Fit errors produced:
    17501 successful fits.
    Error 1 occurred 176 times.
    Error 2 occurred 2446 times.
    Error 3 occurred 16455 times.
    Error 4 occurred 1701 times.

%MSG

@mark-grimes
Copy link
Author

Please test

@cmsbuild cmsbuild added this to the Next CMSSW_6_2_X_SLHC milestone Jan 16, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Reduce fit errors in HCal local reco to a summary

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link
Author

merge

Change above is a rebase after a conflict when #7174 was merged.

@cmsbuild
Copy link
Contributor

Pull request #7205 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

cmsbuild added a commit that referenced this pull request Jan 16, 2015
Reduce fit errors in HCal local reco to a summary
@cmsbuild cmsbuild merged commit 60e2a35 into cms-sw:CMSSW_6_2_X_SLHC Jan 16, 2015
@mark-grimes mark-grimes deleted the summariseFitErrors branch January 16, 2015 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants