Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug PF collections to Shashlik event content #7211

Merged

Conversation

mark-grimes
Copy link

Adds the collections particleFlowRecHitHBHE and particleFlowClusterHBHE to the Shashlik FEVTDEBUGHLTEventContent.

Note that this wasn't added to the Shashlik without extended pixel customisation, I wasn't sure if this is required long term. This can be checked once the Shashlik relvals are underway.

Tested with 13861 and used edmDumpEventContent to make sure the reco output file had the collections.

@boudoul, @hengne, @bachtis

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add debug PF collections to Shashlik event content

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

Please test

Tested 13861 privately but no harm in doing the full set.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link
Author

Merge

@mark-grimes
Copy link
Author

merge

Try again, waiting on this before requesting the build.

cmsbuild added a commit that referenced this pull request Jan 16, 2015
Add debug PF collections to Shashlik event content
@cmsbuild cmsbuild merged commit 4a25688 into cms-sw:CMSSW_6_2_X_SLHC Jan 16, 2015
@mark-grimes mark-grimes deleted the addShashlikCollections branch January 23, 2015 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants