Resolve Clang issues in DQMOffline/Trigger #7212
Conversation
The patch resolves the following error:
error: address of 'this->m_triggerResults' will
always evaluate to 'true'
Taking an address of `triggerResults_` and implicitly converting to bool
will always yield true.
I believe author wanted `triggerResults_.isValid()`.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
`ParameterSet` is not a templated class, but `getParameter<>()` method
is templated. If the method is called in a templated class via some
indirection (e.g., via array element):
a[i].getParameter<int>("...")
`template` keyword is needed for Clang pre-3.6 (65d8b4c).
I believe this is wrong, but having `template` keyword should not harm
the code. It tell compiler that `getParameter<>()` name needs to be
looked up as a template.
See PR22247: http://llvm.org/bugs/show_bug.cgi?id=22247
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_4_X. Resolve Clang issues in DQMOffline/Trigger It involves the following packages: DQMOffline/Trigger @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
|
Thanks! |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Resolve Clang issues in DQMOffline/Trigger
This is another round of fixes for
DQMOffline/Trigger. Note that this package was already building fine under Clang at the end of November. Also fixing the package resulted in a bug report for Clang (details in commit and diff).Build tested with GCC 4.9.1 and Clang pre-3.6 (
65d8b4c) in DEVEL IB.