Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Clang issues in DQMOffline/Trigger #7212

Merged
merged 3 commits into from Jan 16, 2015
Merged

Resolve Clang issues in DQMOffline/Trigger #7212

merged 3 commits into from Jan 16, 2015

Commits on Jan 16, 2015

  1. Resolve errors where address is used in if-statement 

    The patch resolves the following error:

    error: address of 'this->m_triggerResults' will
    always evaluate to 'true'

Taking an address of `triggerResults_` and implicitly converting to bool
will always yield true.

I believe author wanted `triggerResults_.isValid()`.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Jan 16, 2015
    Configuration menu
    Copy the full SHA
    833626c View commit details
    Browse the repository at this point in the history

  2. Use 'template' keyword for getParameter<>() call 

    `ParameterSet` is not a templated class, but `getParameter<>()` method
is templated. If the method is called in a templated class via some
indirection (e.g., via array element):

    a[i].getParameter<int>("...")

`template` keyword is needed for Clang pre-3.6 (65d8b4c).

I believe this is wrong, but having `template` keyword should not harm
the code. It tell compiler that `getParameter<>()` name needs to be
looked up as a template.

See PR22247: http://llvm.org/bugs/show_bug.cgi?id=22247

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Jan 16, 2015
    Configuration menu
    Copy the full SHA
    5ac210a View commit details
    Browse the repository at this point in the history

  3. Remove unsed private field (m_isSetup) 

    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Jan 16, 2015
    Configuration menu
    Copy the full SHA
    f18ce50 View commit details
    Browse the repository at this point in the history