Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DQM statics #7240

Merged
merged 4 commits into from Jan 19, 2015
Merged

Fix DQM statics #7240

merged 4 commits into from Jan 19, 2015

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Jan 16, 2015

I had to put back the thread_unsafe::DQMEDAnalyzer class

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 16, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_4_X.

Fix DQM statics

It involves the following packages:

DQM/L1TMonitor
DQMServices/Core

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

please test

Dr15Jones
Dr15Jones reviewed Jan 17, 2015
View reviewed changes
DQM/L1TMonitor/src/L1TdeRCT.cc
first = false ;
}

if(first)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the only place first is used in the file, I think it can be just dropped :).

@deguio
Copy link
Contributor Author

deguio commented Jan 19, 2015

+1
thanks chris.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3d44170
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7240/1981/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 19, 2015
@cmsbuild
Merge pull request #7240 from deguio/fixStatics74x
52f9ff7 
Fix DQM statics
@cmsbuild cmsbuild merged commit 52f9ff7 into cms-sw:CMSSW_7_4_X Jan 19, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7240/1981/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deguio @cmsbuild @davidlange6 @Dr15Jones