Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update residual decays and verbosity #7255

Merged
merged 1 commit into from Jan 17, 2015

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano for CMSSW_7_4_X.

Update residual decays and verbosity

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@bendavid
Copy link
Contributor

Is this needed to have working residual decays after the previous fix?

@mkirsano
Copy link
Contributor Author

There is residualDecay also in Pythia8 Guns, it was not fixed in the previous fix.
There is a small improvement of HepMCA2.h (needed to ask for inclusion in pythia8). For CMSSW it will work as before.
And additional verbosity of Pythia8Interface

@bendavid
Copy link
Contributor

OK thanks. What is the improvement in hepmca2?

@mkirsano
Copy link
Contributor Author

In the first variant the barcodes of added particles did not continue the previous barcode sequence. Now by default they continue it. And I put back some features that existed in the standard HepMC2.h.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 17, 2015
Update residual decays and verbosity
@cmsbuild cmsbuild merged commit 61fc17d into cms-sw:CMSSW_7_4_X Jan 17, 2015
@cmsbuild
Copy link
Contributor

bendavid pushed a commit to bendavid/cmssw that referenced this pull request Jan 18, 2015
hroskes pushed a commit to hroskes/cmssw that referenced this pull request Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants