Add fillDescription methods. #7264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by a ref
The patch resolves issue with Clang compiler.
N3690 (should be C++11 standard), 9.4.2/3
...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.
`IsolatedGenParticles::BookHistograms()` was passing them by a
reference.
9.4.2/4 talks about how `const static` data members are being handled.
Also standard says that no diagnostic is required by compiler.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
… a ref
The patch resolves issue with Clang compiler.
N3690 (should be C++11 standard), 9.4.2/3
...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.
9.4.2/3 talks about how `const static` data members are being handled.
Also standard says that no diagnostic is required by compiler.
This is needed to compile RecoLocalCalo/HcalRecAlgos
(HBHENegativeFlag.cc), which passes `MAXSAMPLES` to `std::min`
(arguments are taken by a const ref).
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
The following fix is required due to a behavior difference between Clang and GCC. Clan does not correctly emulate GCC visibility pragma. See PR22254: http://llvm.org/bugs/show_bug.cgi?id=22254 The link error involved the following two symbols: - `Plane::tangentPlane(Point3DBase<float, LocalTag> const&) const` - `Plane::tangentPlane(Point3DBase<float, GlobalTag> const&) const` On link command we have `libTrackingToolsDetLayers.so` and `libTrackingToolsGeomPropagators.so`, which have undefined references for above two symbols. These are usually resolved on dynamic loading. On Clang `TECLayer.o` marked these particular symbols as HIDDEN. Clang: 182: 0000000000000000 0 NOTYPE GLOBAL HIDDEN UND _ZNK5Plane12tangentPlaneERK11Point3DBaseIf8LocalTagE 183: 0000000000000000 0 NOTYPE GLOBAL HIDDEN UND _ZNK5Plane12tangentPlaneERK11Point3DBaseIf9GlobalTagE GCC: 261: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND _ZNK5Plane12tangentPlaneERK11Point3DBaseIf9GlobalTagE 262: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND _ZNK5Plane12tangentPlaneERK11Point3DBaseIf8LocalTagE `TkDetUtil.h` inside visibility pragma section has forward declaration of class `Plane`. Thus Clang marked it as HIDDEN. Then linker was complaining that two libraries mentioned above reference a HIDDEN symbols, which is not allowed as these sybmols are not public API. In GCC `Plane` is with DEFAULT visbility, because the first declaration wins, thus the DEFAULT visibility. You cannot modify it later on. Lesson here: do not add forward declaration for publicly available classes in pragma visibility hidden section. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
…ack selection criteria
|
Hi alca and operations, what is holding up you signing this PR? |
|
+1 |
|
@davidlange6 @nclopezo |
|
@Martin-Grunewald - live is easier when PRs are not rebased in strange ways. as the alca signature requirement is bogus, I'll bypass. |
davidlange6
added a commit
that referenced
this pull request
Jan 30, 2015
Add fillDescription methods.
|
@davidlange6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing fillDescription methods needed for HLT.