Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make silent tests of Shashlik cells validity #7274

Conversation

fratnikov
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fratnikov (Fedor Ratnikov) for CMSSW_6_2_X_SLHC.

make silent tests of Shashlik cells validity

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor

boudoul commented Jan 20, 2015

Thanks @fratnikov for making the logs more silent !
Maybe more for @bsunanda : it might be more consistent, at some point, not to have the code of ShashlikDDDConstants under HGCALCommonData...

@fratnikov
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Jan 20, 2015
…uadrant

make silent tests of Shashlik cells validity
@cmsbuild cmsbuild merged commit 1caec2c into cms-sw:CMSSW_6_2_X_SLHC Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants