Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating TrigXMonitor to new DQM API #7275

Merged

Conversation

vanbesien
Copy link
Contributor

Migrated the following 4 modules to the new DQM api:
DQM/TrigXMonitor/interface/HLTScalers
DQM/TrigXMonitor/interface/HLTSeedL1LogicScalers
DQM/TrigXMonitor/interface/L1Scalers
DQM/TrigXMonitor/interface/L1TScalersSCAL

The only problem we encountered was that HLTScalers was waiting to book some histograms up to the moment it was analyzing the first event in a run. Because it was using the size of the hltResult to book the histograms.
We solved this by using the size of the hltConfig instead at booking time.
This was explicitly tested by comparing the resulting numbers from both methods.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_7_4_X.

Migrating TrigXMonitor to new DQM API

It involves the following packages:

DQM/TrigXMonitor

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@deguio
Copy link
Contributor

deguio commented Jan 20, 2015

test please

@deguio
Copy link
Contributor

deguio commented Jan 20, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 20, 2015
…XMonitor

Migrating TrigXMonitor to new DQM API
@cmsbuild cmsbuild merged commit 5549857 into cms-sw:CMSSW_7_4_X Jan 20, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants