Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastTimerService: thread-safe fix in preStreamBeginRun #7307

Merged
merged 1 commit into from Jan 22, 2015
Merged

FastTimerService: thread-safe fix in preStreamBeginRun #7307

merged 1 commit into from Jan 22, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 21, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 21, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

FastTimerService: thread-safe fix in preStreamBeginRun

It involves the following packages:

HLTrigger/Timer

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@fwyzard fwyzard force-pushed the FastTimerService_fix_preStreamBeginRun branch from ac99e94 to b8246d1 Compare January 21, 2015 18:42
@fwyzard fwyzard force-pushed the FastTimerService_fix_preStreamBeginRun branch from b8246d1 to 504180e Compare January 21, 2015 18:43
@cmsbuild
Copy link
Contributor

Pull request #7307 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@ghost
Copy link

ghost commented Jan 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

+1
Tested at: 504180e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7307/2049/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 22, 2015
@cmsbuild
Merge pull request #7307 from fwyzard/FastTimerService_fix_preStreamB…
a45a779 
…eginRun

FastTimerService: thread-safe fix in preStreamBeginRun
@cmsbuild cmsbuild merged commit a45a779 into cms-sw:CMSSW_7_4_X Jan 22, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7307/2049/summary.html

@fwyzard fwyzard deleted the FastTimerService_fix_preStreamBeginRun branch February 8, 2015 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @Martin-Grunewald