Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable edmCheckClassVersion, and fail on missing base class dictionary #7311

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 21, 2015

Re-enable edmCheckClassversion, and add code to raise an exception if attempting to calculate the checksum of a class when a base class is unavailable. This will prevent an incorrect checksum from being returned.
Pleas merge this pull request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

Reenable edmCheckClassVersion, and fail on missing base class dictionary

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

davidlt added a commit that referenced this pull request Jan 21, 2015
Reenable edmCheckClassVersion, and fail on missing base class dictionary
@davidlt davidlt merged commit 03cbbf0 into cms-sw:CMSSW_7_4_ROOT6_X Jan 21, 2015
@wmtan wmtan deleted the ReEnableEdmCheckChassVersion branch January 23, 2015 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants