Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing Upgrade WFs in RunTheMatrix #7313

Merged
merged 1 commit into from Jan 22, 2015
Merged

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jan 22, 2015

This PR is adding the upgrade workflows in RunTheMatrix
While large software developments are still needed to make the upgrade geometries working in 74X, runTheMatrix is now ready for the different configurations as it was defined in 62XSLHC and will also help developers to get recipe when developing the ugrade software
This change is not impacting any of the standard workflows used in IBs or during the injection of the relvals.
The upgrade workflows can only be called with the --what upgrade option and therefore are not run in IBs. (until we have something really running)
@mark-grimes : FYI

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_4_X.

Preparing Upgrade WFs in RunTheMatrix

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@franzoni
Copy link

+1

HI @boudoul , what you propose is all fine. A few tests revealed no problems.
Two comments, which are for us PdmV ( @srimanob ) and offline more in general

  • handling "epochs" / "eras" in a systematic way which is not only top-level dictionaries is the organic way of managing multiple versions of the CMS experiment co-existing in the same release; besides relval, also production sequences (e.g. : recent need of different L1 emulation sequences for 50ns, 25ns ) could be handled more cleanly that way.
    @davidlange6 we spoke about this a year ago or os, you said at the time there was development ongoing, can we try anything out ?
  • more relval -specific: we could forward-think and figure out if / which commonality do we expect to have between the runII- and upgrade-specific dictionary/tuples . Better merging all options in the same file or splitting ? "relval_upgrade.py " and upgradeWorkflowComponents.py could merge in one.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@davidlange6
Copy link
Contributor

There is a pull request implementing eras in 74x since a while. (Thanks to @mark-grimes ) - it needs some attention from me.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 22, 2015
Preparing Upgrade WFs in RunTheMatrix
@cmsbuild cmsbuild merged commit 2f349b2 into cms-sw:CMSSW_7_4_X Jan 22, 2015
@cmsbuild
Copy link
Contributor

@franzoni
Copy link

thanks @davidlange6 @mark-grimes good news about eras!
Can you let us PdmV know @boudoul @srimanob know when we can take a look, and understand implications for production and relvals ? Tks.

@franzoni
Copy link

@davidlange6 @mark-grimes, which one is the PR in question ?
@boudoul @srimanob

@davidlange6
Copy link
Contributor

#6784
which can be found via the github search (or the 74x PR list)
https://github.com/cms-sw/cmssw/search?q=era&type=Issues&utf8=✓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants