Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DQM warnings from FSQ client during cosmics workflows #7321

Closed
wants to merge 1 commit into from

Conversation

fruboes
Copy link
Contributor

@fruboes fruboes commented Jan 22, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fruboes for CMSSW_7_4_X.

Fix DQM warnings from FSQ client during cosmics workflows

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ktf
Copy link
Contributor

ktf commented Jan 23, 2015

@cmsbuild please test

1 similar comment
@ghost
Copy link

ghost commented Jan 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Jan 26, 2015

thanks @fruboes
why don't you remove the fsq module from:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/DQMOffline/Configuration/python/DQMOfflineCosmics_SecondStep_cff.py

instead from
Configuration/StandardSequences/python/HarvestingCosmics_cff.py
?

in this way we don't spread the sequence definition all around CMSSW.

sounds good?
thanks,
F.

@ktf
Copy link
Contributor

ktf commented Jan 27, 2015

@Degano what happened to the tests?

@ghost
Copy link

ghost commented Jan 27, 2015

@ktf this PR is suffering from the missing refs bug. I restarted the tests pointing to the branch instead.

@fruboes
Copy link
Contributor Author

fruboes commented Jan 28, 2015

Dear @deguio,

sorry for a late reply. I should be able to look at this again early next week

Cheers,
Tomasz

@deguio
Copy link
Contributor

deguio commented Feb 3, 2015

ciao @fruboes
74x is closing today. do you think you can converge on this in the next hours?

thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@ktf
Copy link
Contributor

ktf commented Feb 4, 2015

Any updates on this?

@ktf ktf self-assigned this Feb 4, 2015
@fruboes
Copy link
Contributor Author

fruboes commented Feb 5, 2015

should be ready soon (working on it), apologies for a very late followup

@fruboes
Copy link
Contributor Author

fruboes commented Feb 5, 2015

Created a new PR: #7570

@ktf
Copy link
Contributor

ktf commented Feb 5, 2015

Please close this one.
On Thu 5 Feb 2015 at 10:09 fruboes notifications@github.com wrote:

Created a new PR: #7570 #7570


Reply to this email directly or view it on GitHub
#7321 (comment).

@fruboes fruboes closed this Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants