Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74X fixes to CSC Digitization/Trigger paths for PreMixing #7373

Merged
merged 1 commit into from Jan 26, 2015

Conversation

mdhildreth
Copy link
Contributor

cleanup to drop error messages in PreMixing Step, proper treatment of CSC digis now that the MC Packer is run by default.

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_4_X.

74X fixes to CSC Digitization/Trigger paths for PreMixing

It involves the following packages:

Configuration/PyReleaseValidation
SimGeneral/DataMixingModule

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

@mdhildreth - this means we can remove the premix customize functions altogether? (for the next PR)
Given that RECO with premixing is not functioning,I'll bypass this

davidlange6 added a commit that referenced this pull request Jan 26, 2015
74X fixes to CSC Digitization/Trigger paths for PreMixing
@davidlange6 davidlange6 merged commit 613da6f into cms-sw:CMSSW_7_4_X Jan 26, 2015
@mdhildreth
Copy link
Contributor Author

Unless they are not used at all by default, you still need the PostLS1PreMixing customize for the Digi step (step2), since it gives the trigger the correct CSC inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants