HeavyIons: switch photon tracking isolation collection to hiGeneralTracks

[harmonicoscillator]

With the 73X reconstruction improvements to HI, photon tracker isolation should be computed using the new tracking collection.

The previous tracking collection (hiGoodTracks) does not even exist anymore, so tracking isolation DQM histograms were just empty and we were re-running the isolation calculation at analysis level.

[cmsbuild]

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_4_X.

HeavyIons: switch photon tracking isolation collection to hiGeneralTracks

It involves the following packages:

RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[ghost]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 2bd84f0
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 27-Jan-2015 12:00:26 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module HBHEIsolatedNoiseReflagger/'hbhereco'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: trackExtrapolator
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 27-Jan-2015 12:01:19 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module HBHEIsolatedNoiseReflagger/'hbhereco'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: trackExtrapolator
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7374/2134/summary.html

[harmonicoscillator]

This failure is very very surprising to me since it appears to be in a pp workflow. The HI workflow tests ran okay - I will double check why a change to the HI-specific isolation parameters made HBHE reco fail in a pp workflow, but does anyone else have any idea what happened?

[davidlange6]

please test
(the error above was in the IB itself)

[ghost]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 2bd84f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7374/2156/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7374/2156/summary.html

[slava77]

.. I'm checking this

[slava77]

+1

for #7374 2bd84f0
tested in CMSSW_7_4_0_pre6 /test area sign500 /

checked on 200 events of UPC data in wflow 140.53.
The change is as expected: the isolation is filled

The most relevant CPU change is an increase in the photons, as expected

  delta/mean delta/orJob     original                   new       module name
  ---------- ------------     --------                  ----       ------------
   +1.033612      +0.09%        30.62 ms/ev ->        96.12 ms/ev photons

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.