Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary mutable designations from HcalDcsValues #7379

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer complained about thread-unsafe mutables in the
class. As the mutable was unnecessary, it was removed.

The static analyzer complained about thread-unsafe mutables in the
class. As the mutable was unnecessary, it was removed.
@Dr15Jones
Copy link
Contributor Author

@ktf this change is trivial

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

removed unnecessary mutable designations from HcalDcsValues

It involves the following packages:

CondFormats/HcalObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

ktf added a commit that referenced this pull request Jan 27, 2015
…HcalDcsValues

removed unnecessary mutable designations from HcalDcsValues
@ktf ktf merged commit 76d3f90 into cms-sw:CMSSW_7_4_X Jan 27, 2015
@Dr15Jones Dr15Jones deleted the removeUnnecessaryMutablesFromHcalDcsValues branch March 4, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants