Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preallocate signal for Services #738

Merged
merged 1 commit into from Sep 9, 2013

Conversation

Dr15Jones
Copy link
Contributor

Services can now listen for the preallocate Service in order to determine the maximum number of concurrent Streams, Lumis and Runs the system will use for the job.

Services can now listen for the preallocate Service in order to determine the maximum number of concurrent Streams, Lumis and Runs the system will use for the job.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2013

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Added preallocate signal for Services

It involves the following packages:

FWCore/ServiceRegistry
FWCore/Framework

@Dr15Jones, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

This adds a new signal not used by any Services yet so there is no possibility it could break anything. Just to be paranoid, I did run all the framework unit tests and everything passed.

In my opinion, this is safe to merge without any further testing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

nclopezo added a commit that referenced this pull request Sep 9, 2013
@nclopezo nclopezo merged commit 15bdfa6 into cms-sw:CMSSW_7_0_X Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants