Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim sampling of nuclear interation using Geant4 FTF model #7389

Merged
merged 2 commits into from Jan 28, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jan 27, 2015

An alternative method to sample nuclear interaction inside tracker is introduced. Geant4 FTF model is used. New option is disabled by default, so current FastSim results should be unchanged.

Extra dependences of FastSim on clhep and Geant4 are added.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_4_X.

FastSim sampling of nuclear interation using Geant4 FTF model

It involves the following packages:

FastSimulation/MaterialEffects

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@lveldere
Copy link
Contributor

+1

@civanch

did I get this right:
to switch this on set
NuclearInteraction = cms.bool(True)
G4NuclearInteraction = cms.bool(True)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

-1
Tested at: 0181a82
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/MaterialEffects.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/MaterialEffectsSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/MultipleScatteringSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/MuonBremsstrahlungSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc:7:75: fatal error: FastSimulation/MaterialEffects/interface/CMSDummyDeexcitation.h: No such file or directory
 #include "FastSimulation/MaterialEffects/interface/CMSDummyDeexcitation.h"
                                                                           ^
compilation terminated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionSimulator.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc:7:75: fatal error: FastSimulation/MaterialEffects/interface/CMSDummyDeexcitation.h: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7389/2147/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

@cmsbuild
Copy link
Contributor

-1
Tested at: 0181a82
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/MuonBremsstrahlungSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/PairProductionSimulator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/PetrukhinModel.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc:7:75: fatal error: FastSimulation/MaterialEffects/interface/CMSDummyDeexcitation.h: No such file or directory
 #include "FastSimulation/MaterialEffects/interface/CMSDummyDeexcitation.h"
                                                                           ^
compilation terminated.
Entering library rule at FastSimulation/Calorimetry
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-27-0200/src/FastSimulation/MaterialEffects/test/testNuclearInteractions.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7389/2146/summary.html

@civanch
Copy link
Contributor Author

civanch commented Jan 27, 2015

Sorry incorrect file was committed

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor Author

civanch commented Jan 28, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 28, 2015
FastSim sampling of nuclear interation using Geant4 FTF model
@cmsbuild cmsbuild merged commit 0313116 into cms-sw:CMSSW_7_4_X Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants