Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the list of path monitored in the muon HLT DQM #7392

Merged

Conversation

HuguesBrun
Copy link
Contributor

addition of 4 more paths

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_4_X.

update the list of path monitored in the muon HLT DQM

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Jan 30, 2015

please test

@deguio
Copy link
Contributor

deguio commented Feb 2, 2015

please test

@deguio
Copy link
Contributor

deguio commented Feb 2, 2015

would like to check the tests before approving.
@HuguesBrun how many histograms does this add?
thanks,
F.

@davidlange6
Copy link
Contributor

@nclopezo , @Degano - seems this PR needs its tests run by hand

@nclopezo
Copy link
Contributor

nclopezo commented Feb 3, 2015

Hi David, I started them manually.

@HuguesBrun
Copy link
Contributor Author

Hello, @deguio,
I noticed that I need to update a bit the way the muon DQM code is parsing the filters due to the fact we switched recently to the PF isolation.
Would you mind if I update this PR or do you prefer I submit an other one for that ? (I am testing the changes right now but lxplus is superslow this morning...)
thank you !

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@HuguesBrun
Copy link
Contributor Author

Hello again,
I just updated the PR in order to handle the new HLT filters introduced by the use on PF isolation on isolated muon path.

I checked the size increase of the HLT/Muons directory, the result is here:

folder HLT/Muons histograms bins Empty bins Empty/Total bins per histogram MB kB per histogram
before 2728 757248 124507 0.164 278 2.95 1.11
after 3600 778468 142803 0.183 216 3.03 0.862

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

Pull request #7392 was updated. @danduggan, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@deguio
Copy link
Contributor

deguio commented Feb 3, 2015

+1
@HuguesBrun please make sure that the old/not interesting HLT paths are removed.
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 3, 2015
…n740pre5

update the list of path monitored in the muon HLT DQM
@cmsbuild cmsbuild merged commit bf80b10 into cms-sw:CMSSW_7_4_X Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants