Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get DataFormats/Math to compile on ICC. #7395

Merged
merged 1 commit into from Jan 29, 2015
Merged

Get DataFormats/Math to compile on ICC. #7395

merged 1 commit into from Jan 29, 2015

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jan 27, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Get DataFormats/Math to compile on ICC.

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

please test

@davidlt
Copy link
Contributor

davidlt commented Jan 28, 2015

ExtVec_t.cpp is crashing ICC IIRC. I will try to find a minimal testcase for Intel.

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@ktf
Copy link
Contributor Author

ktf commented Jan 28, 2015

Intel already knows about this. Nothing do be done on your side.

@cmsbuild
Copy link
Contributor

+1
Tested at: 04a6b77
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7395/2172/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7395/2172/summary.html

@ktf
Copy link
Contributor Author

ktf commented Jan 29, 2015

Changes are trivial. Bypassing reco signature. Complain if not ok.

ktf added a commit that referenced this pull request Jan 29, 2015
@ktf
Merge pull request #7395 from ktf/fix-icc
b8548b9 
Get DataFormats/Math to compile on ICC.
@ktf ktf merged commit b8548b9 into cms-sw:CMSSW_7_4_X Jan 29, 2015
@ktf ktf deleted the fix-icc branch January 29, 2015 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available pending-signatures reconstruction-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktf @cmsbuild @davidlange6 @davidlt