Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused member variable from CastorDbService #7398

Merged
merged 1 commit into from Jan 28, 2015
Merged

Remove unused member variable from CastorDbService #7398

merged 1 commit into from Jan 28, 2015

Conversation

Dr15Jones
Copy link
Contributor

An unused member variable was marked as mutable which was flagged
as a problem by the static analyzer.

@Dr15Jones
Remove unused member variable from CastorDbService
5e9fb1a 
An unused member variable was marked as mutable which was flagged
as a problem by the static analyzer.
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Remove unused member variable from CastorDbService

It involves the following packages:

CalibFormats/CastorObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@davidlange6
Copy link
Contributor

please test

@ghost
Copy link

ghost commented Jan 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5e9fb1a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7398/2179/summary.html

@Dr15Jones
Copy link
Contributor Author

@ktf this change is trivial.

@diguida
Copy link
Contributor

diguida commented Jan 28, 2015

+1
unused reco::castor::QieShape* mQieShapeCache.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 28, 2015
@cmsbuild
Merge pull request #7398 from Dr15Jones/removeUnneededMutableFromCast…
fc1964d 
…orDbService

Remove unused member variable from CastorDbService
@cmsbuild cmsbuild merged commit fc1964d into cms-sw:CMSSW_7_4_X Jan 28, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7398/2179/summary.html

@Dr15Jones Dr15Jones deleted the removeUnneededMutableFromCastorDbService branch February 25, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-pending fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @davidlange6 @diguida