Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes to CSCSegment #743

Merged
merged 5 commits into from Sep 10, 2013
Merged

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Sep 9, 2013

Add consumes interface to CSCSegment. Of course this also includes addition of consumes interface to CSCRecHitD. I have not added consumes interface to two programs in test, CSCSegmentReader and CSCSegment Visualise because these obvioulsy haven't been used in a while and would need more updating than just the consumes interface to run. Not only that I find the config files to run them were deleted from cvs almost 5 years ago. I added a new config to test which runs a 100 event dump of CSC rechits and segments based on a relval raw data sample in 700pre3.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2013

A new Pull Request was created by @ptcox for CMSSW_7_0_X.

Consumes to CSCSegment

It involves the following packages:

RecoLocalMuon/CSCSegment
RecoLocalMuon/CSCRecHitD

@thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@thspeer
Copy link
Contributor

thspeer commented Sep 9, 2013

Working @thspeer

@nclopezo
Copy link
Contributor

Hi,

I ran the tests on top of CMSSW_7_0_X_2013-09-10-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/423/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/423

@thspeer
Copy link
Contributor

thspeer commented Sep 10, 2013

+1
Jenkins test ok
Tested at 985b437 in CMSSW_7_0_X_2013-09-09-0200-743
No difference in reco, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@thspeer thspeer mentioned this pull request Sep 10, 2013
ktf added a commit that referenced this pull request Sep 10, 2013
@ktf ktf merged commit 7c9bf4e into cms-sw:CMSSW_7_0_X Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants