Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove improper call to edm::Ref constructor call #7463

Merged
merged 1 commit into from Jan 30, 2015
Merged

Remove improper call to edm::Ref constructor call #7463

merged 1 commit into from Jan 30, 2015

Commits on Jan 29, 2015

  1. Remove improper call to edm::Ref constructor call 

    The associator was constructing an edm::Ref by passing it an
edm::RefVector and an index. However, the index used was one into
the edm::RefVector but the constructor requires the index to be back
to the original collection to which the edm::RefVector associates.
The only way the associator ever worked correctly was when the edm::RefVector
used contained entries for every item in the original collection.
The problematic edm::Ref constructor will be removed in another commit.
This problem was found by David Dagenhart.
    @Dr15Jones
    Dr15Jones committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    4c59972 View commit details
    Browse the repository at this point in the history