Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dxyError and dzError to Candidate #7479

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 30, 2015

As discussed in private thread, the DF/TrackReco is not pull in Candidate so that the obvious implementation need to be repeated in derived classes (others have different implementation, such as PackedCandidates)

@gpetruc @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_4_X.

Adding dxyError and dzError to Candidate

It involves the following packages:

DataFormats/Candidate
DataFormats/ParticleFlowCandidate
DataFormats/RecoCandidate

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 00ce824
I ran the usual tests and I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7479/2260/summary.html

@slava77
Copy link
Contributor

slava77 commented Jan 30, 2015

@ktf @nclopezo
Did the build running by jenkins choke on the large rebuild side?

@slava77
Copy link
Contributor

slava77 commented Jan 31, 2015

+1

for #7479 00ce824
code is OK
jenkins compiles it fine
no changes expected and none observed

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2015

davidlange6 added a commit that referenced this pull request Feb 2, 2015
…_4_0_pre6

Adding dxyError and dzError to Candidate
@davidlange6 davidlange6 merged commit 3cd918b into cms-sw:CMSSW_7_4_X Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants