Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cosmic mu reco in pp #7541

Merged
merged 4 commits into from Feb 5, 2015

Conversation

trocino
Copy link
Contributor

@trocino trocino commented Feb 3, 2015

This is to skip regional-tracker reco and global-muon reco (both 1- and 2-leg) in the cosmic-muon reconstruction sequence used in collisions. (Note that there is no change in cosmic runs.)
The following modules are removed:
Tracking:
regionalCosmicTracksSeq = regionalCosmicTrackerSeedingLayers * regionalCosmicTrackerSeeds * regionalCosmicCkfTrackCandidates * regionalCosmicTracks
Global-muon reco:
globalCosmicMuons, globalCosmicMuons1Leg
The corresponding event content is also removed.
This is based on the configuration prepared by @bellan. The tracking changes were discussed and agreed on with @VinInn and @rovere.

…isions, only keep standalone and high-levelobject
…isions, only keep standalone and high-levelobject
…isions, only keep standalone and high-levelobject
…isions, only keep standalone and high-levelobject
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

A new Pull Request was created by @trocino (Daniele Trocino) for CMSSW_7_4_X.

Clean up cosmic mu reco in pp

It involves the following packages:

Configuration/StandardSequences
RecoMuon/Configuration
RecoTracker/Configuration

@nclopezo, @cvuosalo, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @bellan, @gpetruc, @cerati, @rociovilar, @dgulhan, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2015

.. I'm checking it

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2015

+1

for #7541 f376e26
tested in CMSSW_7_4_X_2015-02-02-0200 /test area sign513, commits cherry-picked)

In general, changes are as expected.

The banchmark sample for run2 TTbar with PU35@25ns shows reduction in used resources:

  • CPU reduces by 10% (compared to older tests with an independent input sample of 5%, in both cases driven by ~10 events) ==> about 7% CPU reduction. GOOD.
  • AODSIM size decreases by 0.1% (negligible)
  • muonsFromCosmics change slightly, the only more visible change is the matching ecal info (the plot is 10 GeV SingleMuon "dimuon" gun); the standalone muons are not pointing as well to the calorimeter cells as the tracker tracks
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics__reco_obj_calenergy_ems9
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics__reco_obj_calocompatibility
  • muonsFromCosmics1Leg change significantly in muon gun samples (real dimuons)
    (same 10 GeV muon gun sample). In this case pointing capabilities are worse to the HCAL as well
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics1leg__reco_objat_size
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics1leg__reco_obj_calenergy_ecal_time
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics1leg__reco_obj_calenergy_hads9
    all_sign513vsorig_singlemupt10wf20p0c_recomuons_muonsfromcosmics1leg__reco_obj_calocompatibility

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants