Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup nuclear interaction for FastSim #7555

Merged
merged 3 commits into from Feb 4, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 4, 2015

This PR includes #7546 which is already integrated.
Clean-up of parameters and variables names is done to avoid later confusions.
For FTF nuclear interactions hyperons and anti-particle interactions are added.
Some code optimisation for FTF nuclear interaction introduced.
By default FTF nuclear is still disabled.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_4_X.

Cleanup nuclear interaction for FastSim

It involves the following packages:

FastSimulation/Configuration
FastSimulation/MaterialEffects

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@lveldere
Copy link
Contributor

lveldere commented Feb 4, 2015

+1

@civanch

It seems you picked up my #7546 correctly.
Changes to the old code look good, thanks.
I did not check the new code, since this is only in a testing stage.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@lveldere
Copy link
Contributor

lveldere commented Feb 4, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 4, 2015
Cleanup nuclear interaction for FastSim
@cmsbuild cmsbuild merged commit e9d391b into cms-sw:CMSSW_7_4_X Feb 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants