Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File information in playback info #7564

Merged
merged 1 commit into from Mar 7, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 4, 2015

This pull request implements a feature to solve the following problem: When the mixing module is running in playback mode, the input source has no idea in which minbias file each event resides. There could be many minbias files, so the input source needs to open each file one at a time until it finds the correct file. This feature replaces class CrossingFramePlaybackInfoExtended with class CrossingFramePlaybackInfoNew.
The new class contains a hash of the logical file name for each playback event, in principle enabling the source to open only the correct file. CrossingFramePlaybackInfoExtended is kept read only for backward compatibility only. The pull request also replaces the vector of a vector of a vector (no kidding) used in CrossingFramePlaybackInfoExtended with a flat vector in CrossingFramePlaybackInfoNew.
This request has been successfully tested with relval 200. However, since this test uses only one playback file. it is not sufficient testing to ensure functionality.
So, the requestors of this feature (Yetkin Yilmaz et. al.) need to test this or provide some tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

File information in playback info

It involves the following packages:

Configuration/EventContent
DQM/SiStripMonitorHardware
DQMServices/Components
DataFormats/Common
FWCore/Sources
IOPool/Input
IOPool/SecondaryInput
Mixing/Base
SimDataFormats/CrossingFrame
SimGeneral/Configuration
SimGeneral/DataMixingModule
SimGeneral/MixingModule

@civanch, @Dr15Jones, @danduggan, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @deguio, @ktf, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @barvic, @wddgit, @Martin-Grunewald, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

Pull request #7564 was updated. @civanch, @Dr15Jones, @danduggan, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @deguio, @ktf, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@Dr15Jones
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants