New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File information in playback info #7564
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. File information in playback info It involves the following packages: Configuration/EventContent @civanch, @Dr15Jones, @danduggan, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @deguio, @ktf, @davidlange6 can you please review it and eventually sign? Thanks. |
1380099
to
8776939
Compare
Pull request #7564 was updated. @civanch, @Dr15Jones, @danduggan, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @deguio, @ktf, @davidlange6 can you please check and sign again. |
+1 |
File information in playback info
This pull request implements a feature to solve the following problem: When the mixing module is running in playback mode, the input source has no idea in which minbias file each event resides. There could be many minbias files, so the input source needs to open each file one at a time until it finds the correct file. This feature replaces class CrossingFramePlaybackInfoExtended with class CrossingFramePlaybackInfoNew.
The new class contains a hash of the logical file name for each playback event, in principle enabling the source to open only the correct file. CrossingFramePlaybackInfoExtended is kept read only for backward compatibility only. The pull request also replaces the vector of a vector of a vector (no kidding) used in CrossingFramePlaybackInfoExtended with a flat vector in CrossingFramePlaybackInfoNew.
This request has been successfully tested with relval 200. However, since this test uses only one playback file. it is not sufficient testing to ensure functionality.
So, the requestors of this feature (Yetkin Yilmaz et. al.) need to test this or provide some tests.