Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling of corrupted orbit ID and timestamp;Added support for file path convention of DAQ 2 #7565

Merged
merged 2 commits into from Feb 7, 2015

Conversation

grasph
Copy link
Contributor

@grasph grasph commented Feb 4, 2015

Added handling of corrupted orbit ID and timestamp
Added support for file path convention of DAQ 2

Code used in P5 for ECAL laser monitoring system.

Added support for file path convention of DAQ 2
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

A new Pull Request was created by @grasph for CMSSW_7_4_X.

Added handling of corrupted orbit ID and timestamp;Added support for file path convention of DAQ 2

It involves the following packages:

CalibCalorimetry/EcalLaserSorting
EventFilter/EcalRawToDigi

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@grasph
Copy link
Contributor Author

grasph commented Feb 4, 2015

Why did the pull go to CMSSW_7_4_X and not CMSSW_7_3_X? I started from cmsrel CMSSW_7_3_1_patch2 and used git-cms-addpkg.
This commit must be included in all releases > CMSSW_7_3_1_patch2.

@slava77
Copy link
Contributor

slava77 commented Feb 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@diguida
Copy link
Contributor

diguida commented Feb 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants