Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom sequence for PreMixing Reco #7623

Merged
merged 1 commit into from Feb 9, 2015

Conversation

mdhildreth
Copy link
Contributor

Take out mods for bypassing CSC Raw2Digi in Reco step. They aren't needed anymore.

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

A new Pull Request was created by @mdhildreth for CMSSW_7_4_X.

Remove custom sequence for PreMixing Reco

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@franzoni
Copy link

franzoni commented Feb 9, 2015

hello @mdhildreth , "They aren't needed anymore."
does that imply that postLS1CustomsPreMixing can be taken out of the release, altogether (it's only used in the file you've modified, as far as I Can see..)?

@davidlange6
Copy link
Contributor

@franzoni - it should still be needed in the step of making premixed events. (@mdhildreth can correct me) - I will merge this as in any case premixing is not working in the IBs.

davidlange6 added a commit that referenced this pull request Feb 9, 2015
Remove custom sequence for PreMixing Reco
@davidlange6 davidlange6 merged commit 2cef07d into cms-sw:CMSSW_7_4_X Feb 9, 2015
@franzoni
Copy link

franzoni commented Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants