Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalibCalorimetry/EcalLaserSorting (LaserSorter.cc): remove unused variables #7629

Merged
merged 1 commit into from Feb 9, 2015
Merged

CalibCalorimetry/EcalLaserSorting (LaserSorter.cc): remove unused variables #7629

merged 1 commit into from Feb 9, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 9, 2015

The patch removes unused variables detected by Clang pre-3.6.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

CalibCalorimetry/EcalLaserSorting (LaserSorter.cc): remove unused var…
6fa0a0f 
…iables

The patch removes unused variables detected by Clang pre-3.6.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Feb 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

A new Pull Request was created by @davidlt for CMSSW_7_4_X.

CalibCalorimetry/EcalLaserSorting (LaserSorter.cc): remove unused variables

It involves the following packages:

CalibCalorimetry/EcalLaserSorting

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

+1
Tested at: 6fa0a0f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7629/2463/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7629/2463/summary.html

@davidlange6
Copy link
Contributor

trivial - bypassing

davidlange6 added a commit that referenced this pull request Feb 9, 2015
@davidlange6
Merge pull request #7629 from davidlt/clang-fix-CalibCalorimetry-Ecal…
d3cadbf 
…LaserSorting

CalibCalorimetry/EcalLaserSorting (LaserSorter.cc): remove unused variables
@davidlange6 davidlange6 merged commit d3cadbf into cms-sw:CMSSW_7_4_X Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @davidlange6