move Spline to single precision #7632
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X. move Spline to single precision It involves the following packages: PhysicsTools/MVAComputer @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
| double tmp; | ||
| double d = 0.0; | ||
| float tmp; | ||
| float d = 0.0; | ||
| d += coeffs[1]; tmp = x; | ||
| d += coeffs[2] * tmp * 2.0; tmp *= x; |
There was a problem hiding this comment.
better to change all literals to 2.0f, 3.0f etc...
|
still 50MB of floats is 12.5M values: to do what? |
| double tmp; | ||
| double y = 0.0; | ||
| float tmp; | ||
| float y = 0.0; | ||
| y += coeffs[0]; tmp = x; |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Will merge - Only diffs are off by one bin issues in |
move Spline to single precision
to save 50MB in reco (we should also understand why we have 50MB of splines)
Thanks to Danilo for noticing this.
[I didn't check the physics changes - please do before signing]