New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the MAXFEDID according to changes in the FEDNumbering #7634
Conversation
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
@@ -28,6 +28,7 @@ | |||
#include "DataFormats/FEDRawData/interface/FEDNumbering.h" | |||
#include "DQMServices/Core/interface/DQMEDAnalyzer.h" | |||
|
|||
#define MAXFED 4097 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why redefine the value here ?
I'd rather just reuse FEDNumbering::MAXFEDID
A new Pull Request was created by @deguio for CMSSW_7_4_X. update the MAXFEDID according to changes in the FEDNumbering It involves the following packages: DQM/L1TMonitor @danduggan, @deguio can you please review it and eventually sign? Thanks. |
Pull request #7634 was updated. @danduggan, @deguio can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
update the MAXFEDID according to changes in the FEDNumbering
No description provided.