New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed use of try catch for parameter checking #7651
Removed use of try catch for parameter checking #7651
Conversation
The use of try {} catch to determine if a parameter existed was causing on the order of 100 exceptions to be thrown during startup. Changing the code to use 'existsAs' avoids the problem. In addition, the code no longer creates unnecessary std::string temporaries.
This fix is needed to make using |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X. Removed use of try catch for parameter checking It involves the following packages: HLTriggerOffline/Exotica @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Removed use of try catch for parameter checking
The use of try {} catch to determine if a parameter existed was causing
on the order of 100 exceptions to be thrown during startup. Changing the
code to use 'existsAs' avoids the problem.
In addition, the code no longer creates unnecessary std::string temporaries.