Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

73x: New Fireworks aod configuration, additional checks for type ids in newItem callbacks(redo) #7680

Merged
merged 5 commits into from Feb 12, 2015
Merged

73x: New Fireworks aod configuration, additional checks for type ids in newItem callbacks(redo) #7680

merged 5 commits into from Feb 12, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Feb 11, 2015

This is a redo of #7581, where destination branch was false.

@alja alja mentioned this pull request Feb 11, 2015
Closed
@alja
Copy link
Contributor Author

alja commented Feb 11, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Feb 11, 2015
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: e056102
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7680/2534/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 12, 2015
@cmsbuild
Merge pull request #7680 from alja/CaloTower-Crash
d309638 
73x: New Fireworks aod configuration, fix crash in rec-hit view (redo)
@cmsbuild cmsbuild merged commit d309638 into cms-sw:CMSSW_7_3_X Feb 12, 2015
@alja alja changed the title 73x: New Fireworks aod configuration, fix crash in rec-hit view (redo) 73x: New Fireworks aod configuration, additional checks for type ids in newItem callbacks(redo) Feb 23, 2015
@alja alja mentioned this pull request Feb 23, 2015
Merged
@alja alja deleted the CaloTower-Crash branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-approved visualization-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6