Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding pixel cluster properties back for the module level (online dqm) #7701

Merged
merged 2 commits into from Feb 12, 2015
Merged

adding pixel cluster properties back for the module level (online dqm) #7701

merged 2 commits into from Feb 12, 2015

Conversation

danduggan
Copy link
Contributor

Needed patch to have some important online DQM plots filled in the online world. similar PR will go out later for 74X to keep it all in sync. Also put in protection for the beam online application for pixels.

@danduggan
Copy link
Contributor Author

+1
Code change is for online only part of code.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Feb 12, 2015
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @danduggan for CMSSW_7_3_X.

adding pixel cluster properties back for the module level (online dqm)

It involves the following packages:

DQM/Integration
DQM/SiPixelMonitorCluster

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #7701 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@danduggan
Copy link
Contributor Author

+1
(with addition of online config)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@danduggan danduggan mentioned this pull request Feb 12, 2015
Merged
davidlange6 added a commit that referenced this pull request Feb 12, 2015
@davidlange6
Merge pull request #7701 from danduggan/pixclusters-online
7b14dc5 
adding pixel cluster properties back for the module level (online dqm)
@davidlange6 davidlange6 merged commit 7b14dc5 into cms-sw:CMSSW_7_3_X Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed orp-pending tests-started
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danduggan @cmsbuild @davidlange6