Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Strip Noise bug-fix #7725

Merged
merged 2 commits into from Feb 23, 2015
Merged

Conversation

prolaymal
Copy link
Contributor

Single strip Noise bug fix. See the presentation here: https://indico.cern.ch/event/368008/session/4/contribution/9/material/slides/0.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @prolaymal for CMSSW_7_4_X.

Single Strip Noise bug-fix

It involves the following packages:

SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @jlagram, @rovere, @VinInn, @appeltel, @cnuttens, @prolay, @cerati, @venturia, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Feb 13, 2015

@prolaymal , please, comment out or remove std::cout

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Feb 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@VinInn
Copy link
Contributor

VinInn commented Mar 10, 2015

How this PR was tested?

@davidlange6
Copy link
Contributor

that is a loaded question... we looked at (and got confirmation from both sim and tracker) the IB comparison plots (I think the discussion was in the 75x PR)

#7776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants