New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puppi bug fixes from Jochen Ott #7733
Conversation
A new Pull Request was created by @nhanvtran for CMSSW_7_4_X. puppi bug fixes from Jochen Ott It involves the following packages: CommonTools/PileupAlgos @nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 This PR makes small code changes to protect against a possible division by zero and a possible negative array index reference. Prior to this fix, programs that encountered these special situations would probably have crashed. Jenkins tests show no problems or differences, but this PR would not be expected to cause any change in program behavior except in the very rare cases where the particular situations it protects against occur. |
puppi bug fixes from Jochen Ott
a few small code protections in corner cases is added