Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of depreciated SiStripDetId classes from CalibFormats/SiStripObjects #7797

Conversation

cmsbuild
Copy link
Contributor

The usage has been replaced with the TrackerTopology object.
Automatically ported from CMSSW_7_4_X #7631

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_5_X.

Removal of depreciated SiStripDetId classes from CalibFormats/SiStripObjects

It involves the following packages:

CalibFormats/SiStripObjects
CalibTracker/Records
CalibTracker/SiStripESProducers

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@jlagram, @threus, @gbenelli, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor Author

-1
Tested at: 8d7c857
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/EventFilter/SiStripRawToDigi/src/SiStripDetSetVectorFiller.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBuffer.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBufferComponents.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBufferGenerator.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/CommonTools/TrackerMap/src/TrackerMap.cc: In constructor 'TrackerMap::TrackerMap(const edm::ParameterSet&, const SiStripFedCabling*)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/CommonTools/TrackerMap/src/TrackerMap.cc:225:71: error: no matching function for call to 'SiStripDetCabling::SiStripDetCabling(const SiStripFedCabling&)'
    if(enableFedProcessing) detCabling = new SiStripDetCabling( *tkFed );
                                                                       ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/CommonTools/TrackerMap/src/TrackerMap.cc:225:71: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/CommonTools/TrackerMap/src/TrackerMap.cc:7:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-02-18-1400/src/CalibFormats/SiStripObjects/interface/SiStripDetCabling.h:67:3: note: SiStripDetCabling::SiStripDetCabling(const SiStripDetCabling&)


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7797/2737/summary.html

@nickmccoll
Copy link
Contributor

The online changes of this PR have been tested and there are no changes with respect to the original code (as expected).

Btw, @cmsbuild did not register my commits as changes to the PR. Is there some way to trigger that?

@ggovi
Copy link
Contributor

ggovi commented Mar 9, 2015

+1

davidlange6 added a commit that referenced this pull request Mar 10, 2015
…pObjects_toTrackerTopology

Removal of depreciated SiStripDetId classes from CalibFormats/SiStripObjects
@davidlange6 davidlange6 merged commit ac373de into cms-sw:CMSSW_7_5_X Mar 10, 2015
@nickmccoll nickmccoll deleted the my-cmssw/CalibFormats_SiStripObjects_toTrackerTopology branch March 16, 2015 11:26
shervin86 pushed a commit to shervin86/cmssw that referenced this pull request May 11, 2015
…SiStripObjects_toTrackerTopology

Removal of depreciated SiStripDetId classes from CalibFormats/SiStripObjects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants