Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premix cleaning - finish proto-era migration #7826

Merged

Conversation

franzoni
Copy link

  •     complete migration to 3 proto-eras using custom; notably add customisePostLS1_50ns where necessary; see prior discussion at #7579 
    
  •     premix: upgradePLS150ns => run2_mc_50ns; same phy processes as classi mix; include miniaod
    

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_4_X.

Premix cleaning - finish proto-era migration

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link
Author

+1
tested all locally with -ne

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

…ken (customise_csc_hlt was removed from muonCustomsPreMixing); MISSING a combination of postLS1Customs.customisePostLS1_50ns and postLS1CustomsPreMixing
@franzoni
Copy link
Author

SLHCUpgradeSimulations/Configuration/python/postLS1CustomsPreMixing.py was broken when customise_csc_hlt was removed from muonCustomsPreMixing. I propose an obvious fix, @mdhildreth can you please comment/confirm.

@fwyzard @mdhildreth : to handle the DIGI step of the 50ns premixing workflows consistently, we would need a 50ns version of postLS1CustomsPreMixing
(note the two dictionaries digiPremixUp2015Defaults25ns and digiPremixUp2015Defaults50ns in relval_steps.py).
For the sake of running the workflows, I leave postLS1CustomsPreMixing also for the 50ns.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

Thanks! @franzoni

davidlange6 added a commit that referenced this pull request Feb 18, 2015
Premix cleaning - finish proto-era migration
@davidlange6 davidlange6 merged commit 5df5012 into cms-sw:CMSSW_7_4_X Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants