Removed CVS Keywords from Online DB #785
Conversation
|
A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X. Removed CVS Keywords from Online DB It involves the following packages: OnlineDB/EcalCondDB @ggovi, @apfeiffer1 can you please review it and eventually sign? Thanks. |
|
I checked that it compiles here: |
| @@ -4,7 +4,6 @@ PROCEDURE update_online_pvss_iov_date | |||
| new_since IN DATE, | |||
| new_till IN DATE, | |||
| logic_id IN INTEGER ) IS | |||
| /* $id$ | |||
There was a problem hiding this comment.
This is wrong. Please do not remove the beginning of a comment.
ghost
assigned
|
Pull request #785 was updated. @ggovi, @apfeiffer1 can you please check and sign again. |
|
I updated my pull request taking into account not to remove the beginning of a comment. |
| @@ -3320,7 +3320,6 @@ sub define_EE_readout_strip_zseccu_to_EE_readout_strip { | |||
|
|
|||
| push @logic_ids_uni, $logic_ids[$i]; | |||
|
|
|||
| my @channels = split (/ /, $ids[$i]); | |||
There was a problem hiding this comment.
please not this one - it's not a CVS id ... :)
|
Mmm... |
|
well, you do have a "mute thread" button, if you insist ... ;) |
|
Hi, Thanks for your feedback, I updated my pull request again. |
|
You did not clean up what I complained about, though....;) |
|
Pull request #785 was updated. @ggovi, @apfeiffer1 can you please check and sign again. |
|
You mean the removal of the beginning of a comment? Yes I did, I don't know why github is not showing it as an outdated diff. Or, did I miss something else? |
|
Ciao, I meant those, yes, they appear to be in the new commit as well.. I'll check by hand. Ciao, Giulio6-2-25 CERN On Sep 12, 2013, at 1:49 PM, David Mendez notifications@github.com wrote:
|
Removed CVS Keywords from Online DB
|
Seems fine, actually. |
No description provided.