Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output format of MET covariance matrix in MET significance code #7852

Merged
merged 2 commits into from Feb 20, 2015

Conversation

mmarionncern
Copy link

Same as #7832 for CMSSW 75X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_5_X.

Fix output format of MET covariance matrix in MET significance code

It involves the following packages:

RecoMET/METProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @nhanvtran, @mariadalfonso, @TaiSakuma, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Feb 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #7852 37b3481

Small change to improve the format of the new MET covariance matrix (same as #7832, except for 75X instead of 74X). The new code is not configured to run, so it should not create any differences.

The code change is satisfactory, and the Jenkins tests against CMSSW_7_5_X_2015-02-19-1400 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants