Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ecal pfcluster corrections to 73x on top of new GT #7941

Merged
merged 15 commits into from Mar 2, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Feb 25, 2015

May still change in case problems are seen in 74x jet met validation, as in #7690
The code changes are a back port of #7558 with one (removing an ESPrefer and using GT), plus the new set of conditions applied to Run2 simulations in #7692 , and to Run1 simulations, Run1/2 data (including HLT) in #7726 and #7732
The changes in GT are summarised in this Twiki.
New Global Tags for all supported scenarios:

  • added Egamma PF cluster calibrations
  • updated hadron PF calibration.

Global Tags for Run1 simulation contain now as default the SIM geometry with new material budget (so, the ExtendedTest2014 label has been removed).

Rebased on top of CMSSW_7_3_X_2015-02-22-1400.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_3_X.

Backport of ecal pfcluster corrections to 73x on top of new GT

It involves the following packages:

Configuration/AlCa
DataFormats/CaloRecHit
RecoEcal/EgammaCoreTools
RecoHI/Configuration
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @mmarionncern, @Sam-Harper, @MiheeJo, @jazzitup, @lgray, @appeltel, @richard-cms, @yenjie, @echapon, @kurtejung, @argiro, @mandrenguyen, @dgulhan, @bachtis, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Feb 25, 2015

please test

@diguida
Copy link
Contributor Author

diguida commented Feb 25, 2015

Local tests look fine:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Feb 25 00:41:39 2015-date Wed Feb 25 00:33:14 2015; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Feb 25 01:02:55 2015-date Wed Feb 25 00:33:19 2015; exit: 0 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Wed Feb 25 00:39:23 2015-date Wed Feb 25 00:33:22 2015; exit: 0 0
8.0_BeamHalo+BeamHaloINPUT+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Feb 25 00:41:20 2015-date Wed Feb 25 00:33:25 2015; exit: 0 0 0 0 0
25.0_TTbar+TTbarINPUT+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Feb 25 01:01:46 2015-date Wed Feb 25 00:39:29 2015; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Feb 25 00:58:30 2015-date Wed Feb 25 00:41:26 2015; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Feb 25 00:52:59 2015-date Wed Feb 25 00:41:39 2015; exit: 0 0 0 0
7 7 6 6 5 tests passed, 0 0 0 0 0 failed

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@franzoni
Copy link

franzoni commented Mar 3, 2015

hello @davidlange6 ,
what would be the ETA for a 7_3 release including this PR?
Quite a few MC production items will benefit from having the release as soon as reasonable.
Cheers,
g.

@slava77
Copy link
Contributor

slava77 commented Mar 3, 2015

they are in 7_3_3

@slava77
Copy link
Contributor

slava77 commented Mar 3, 2015

@davidlange6
Copy link
Contributor

my estimate for that as of last night 7pm was today. That is still the case

On Mar 3, 2015, at 11:31 AM, Giovanni Franzoni notifications@github.com wrote:

hello @davidlange6 ,
what would be the ETA for a 7_3 release including this PR?
Quite a few MC production items will benefit from having the release as soon as reasonable.
Cheers,
g.


Reply to this email directly or view it on GitHub.

@davidlange6
Copy link
Contributor

Hi again

7_3_3 is now available

Cheers-
David

On Mar 3, 2015, at 3:48 PM, David Lange David.Lange@cern.ch wrote:

my estimate for that as of last night 7pm was today. That is still the case

On Mar 3, 2015, at 11:31 AM, Giovanni Franzoni notifications@github.com wrote:

hello @davidlange6 ,
what would be the ETA for a 7_3 release including this PR?
Quite a few MC production items will benefit from having the release as soon as reasonable.
Cheers,
g.


Reply to this email directly or view it on GitHub.

@franzoni
Copy link

franzoni commented Mar 3, 2015

tks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants