Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove declaration of dupicate dictionary for SMatrix #7955

Merged

Conversation

Dr15Jones
Copy link
Contributor

The dictionaries for SMatrix<double,2> is already declared in libSMatrix
for ROOT 6 and ROOT gives a warning if it also appears in libDataFormatsMath.

The dictionaries for SMatrix<double,2> is already declared in libSMatrix
for ROOT 6 and ROOT gives a warning if it also appears in libDataFormatsMath.
@Dr15Jones
Copy link
Contributor Author

This should fix some of the unit test failures.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_ROOT6_X.

Remove declaration of dupicate dictionary for SMatrix

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2015

this single line was added in #7866 https://github.com/cms-sw/cmssw/pull/7866/files
and it solved a problem there with a missing dictionary.
Where is the other dictionary definition?

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2015

is it just the ROOT6, or will this work for ROOT5?

@Dr15Jones
Copy link
Contributor Author

ROOT 6 declares the dictionary in libSMatrix.so but evidently ROOT 5 did not have it.

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2015

Should we have

#if ROOTVERSION>=6 ? or something like that

On 2/25/15 4:28 PM, Chris Jones wrote:

ROOT 6 declares the dictionary in libSMatrix.so but evidently ROOT 5 did
not have it.


Reply to this email directly or view it on GitHub
#7955 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@Dr15Jones
Copy link
Contributor Author

It was submitted only to the ROOT 6 branch

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

@ktf please merge to fix ROOT6 problems.

nclopezo added a commit that referenced this pull request Feb 26, 2015
Remove declaration of dupicate dictionary for SMatrix
@nclopezo nclopezo merged commit 7e183bc into cms-sw:CMSSW_7_4_ROOT6_X Feb 26, 2015
@Dr15Jones Dr15Jones deleted the removeDuplicateDictForSMatrix branch April 7, 2015 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants