New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove declaration of dupicate dictionary for SMatrix #7955
Remove declaration of dupicate dictionary for SMatrix #7955
Conversation
The dictionaries for SMatrix<double,2> is already declared in libSMatrix for ROOT 6 and ROOT gives a warning if it also appears in libDataFormatsMath.
This should fix some of the unit test failures. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_ROOT6_X. Remove declaration of dupicate dictionary for SMatrix It involves the following packages: DataFormats/Math @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
this single line was added in #7866 https://github.com/cms-sw/cmssw/pull/7866/files |
is it just the ROOT6, or will this work for ROOT5? |
ROOT 6 declares the dictionary in libSMatrix.so but evidently ROOT 5 did not have it. |
Should we have #if ROOTVERSION>=6 ? or something like that On 2/25/15 4:28 PM, Chris Jones wrote:
Vyacheslav (Slava) Krutelyov |
It was submitted only to the ROOT 6 branch |
@cmsbuild please test |
@ktf please merge to fix ROOT6 problems. |
Remove declaration of dupicate dictionary for SMatrix
The dictionaries for SMatrix<double,2> is already declared in libSMatrix
for ROOT 6 and ROOT gives a warning if it also appears in libDataFormatsMath.