Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71X update for 2015 BS and default Run1 geometry #7962

Merged
merged 4 commits into from Mar 16, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Feb 26, 2015

This branch has:

  • a modified version of Configuration/PyReleaseValidation/python/relval_steps.py for using the gen-sim produced in CMSSW_7_1_14 and for using by default the BS for nominal collisions 2015 (originally in 71 x update for2015 bs nm #7904 with a fix);
  • a modified version of Configuration/AlCa/python/autoCond.py for using the GTs for Run2 simulations in 25 and 50 ns with the new BS (originally in 71 x update for2015 bs nm #7904);
  • a modified version of Configuration/AlCa/python/autoCond.py for using the GTs for Run1 simulations with more realistic tracker material budget SIM geometry;
  • a modified version of Configuration/StandardSequences/python/VtxSmeared.py for using the VtxSmearedDefaultKey for NominalCollisions2015 (originally in 71 x update for2015 bs nm #7904).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_1_X.

71X update for 2015 BS and default Run1 geometry

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
Configuration/StandardSequences

@diguida, @boudoul, @franzoni, @cerminar, @cmsbuild, @srimanob, @nclopezo, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Feb 26, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 36f26bd
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7962/2940/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@franzoni
Copy link

@cmsbuild please test

@franzoni
Copy link

can this PR please be merged ?
I tried to re-trigger the tests, which was unsuccessful.
This is essential to have 71x GEN-SIM in input to the 74 validation
(we'll need migration of the matrix to pythia8, too)

@cmsbuild
Copy link
Contributor

-1

Tested at: 54eab43
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7962/7076/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 16, 2015
71X update for 2015 BS and default Run1 geometry
@davidlange6 davidlange6 merged commit 7551361 into cms-sw:CMSSW_7_1_X Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants