Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for enum use in cutParser #7974

Merged
merged 3 commits into from Mar 2, 2015
Merged

Tests for enum use in cutParser #7974

merged 3 commits into from Mar 2, 2015

Conversation

Dr15Jones
Copy link
Contributor

If I run with multiple threads in the ROOT6 we get an intermittent failure from the cutParser. This problem was traced back to TEnum not being thread safe. The test added by this pull request replicates the circumstances of the failure. This test will be useful for monitoring the thread safety of the cutParser for both ROOT 5 and 6.

@Dr15Jones
Add tests for usage of enums in the cutParser
d13c112 
Test for both success and failure when using enums with the cutParser.
@Dr15Jones
Test the cutParser usage with multiple threads
0e6cc75 
Tests using the threaded framework have shown failures using the
cutParser from multiple threads. This test replicates the circumstances
of the failure and if the planets all align can replicate the failure.
@Dr15Jones
Copy link
Contributor Author

@davidlange6 This is the same pull request as #7974 but for 7_4.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Feb 26, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Tests for enum use in cutParser

It involves the following packages:

CommonTools/Utils

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 0e6cc75
I ran the usual tests and I found errors in the following unit tests:

---> test testCommonToolsUtilThreaded had ERRORS
---> test testCommonToolsUtil had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7974/2958/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7974/2978/summary.html

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 1, 2015

+1

For #7974 42a60de

This PR provides a test to monitor the thread safety of the cutParser for both ROOT 5 and 6.

The added code is satisfactory, and the Jenkins tests show no problems.

@slava77
Copy link
Contributor

slava77 commented Mar 1, 2015

+1

trying to see if the bot listens to me

davidlange6 added a commit that referenced this pull request Mar 2, 2015
@davidlange6
Merge pull request #7974 from Dr15Jones/testsForEnumUseInCutParser
eabb839 
Tests for enum use in cutParser
@davidlange6 davidlange6 merged commit eabb839 into cms-sw:CMSSW_7_4_X Mar 2, 2015
@Dr15Jones Dr15Jones deleted the testsForEnumUseInCutParser branch April 7, 2015 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dr15Jones @cmsbuild @cvuosalo @slava77 @davidlange6