Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add softdrop normalization parameter #7978

Merged

Conversation

jdolen
Copy link
Contributor

@jdolen jdolen commented Feb 27, 2015

The soft drop groomer requires three parameters:
https://github.com/cms-externals/fastjet-contrib/blob/master/RecursiveTools/SoftDrop.hh
/// \param beta the value of the beta parameter
/// \param symmetry_cut the value of the cut on the symmetry measure (zcut)
/// \param R0 the angular distance normalisation [1 by default]

By default R0 is set to 1, but ideally it should be set to the jet radius. See equation 1 here:
http://arxiv.org/pdf/1402.2657v2.pdf

The initial CMSSW implementation only included beta and zcut. I've added the R0 parameter and set it to the jet radius for ak8PFJetsCHSSoftDrop, ak4PFJetsSoftDrop, and ak5PFJetsSoftDrop.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jdolen (James Dolen) for CMSSW_7_4_X.

Add softdrop normalization parameter

It involves the following packages:

RecoJets/Configuration
RecoJets/JetProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @TaiSakuma, @ahinzmann, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 2, 2015

Starting extended tests...

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 3, 2015

+1

For #7978 b816f31

An angular distance normalization parameter (R0) to the soft drop jet groomer was changed from its default value to the jet radius for three soft drop jet collections.

The code change is satisfactory. The Jenkins tests are OK and show no significant differences. Extended tests against baseline CMSSW_7_4_X_2015-02-25-1400 for workflows 313.0_QCD_Pt_3000, 1338.0_QCD_FlatPt, 202.0_TTbar, 25202.0_TTbar, and 38.0_QCD_FlatPt show no significant differences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants