Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows to reconstruct HGCal using PandoraPFA #7993

Merged
merged 2 commits into from Mar 2, 2015

Conversation

mark-grimes
Copy link

Creates two new workflows to use HGCal v5 but using PandoraPFA in the reconstruction. Workflows are exactly the same as the normal Extended2023HGCalMuon except that this customisation function is used:

RecoParticleFlow/PandoraTranslator/customizeHGCalPandora_cff.cust_2023HGCalPandoraMuon

Numbers are 156xx for 0 pileup; and 158xx for 140 pileup.
Also fixed some whitespace.

@boudoul, I'd be interested if you have a better way of implementing this. I just replicated the Extended2023HGCalMuon workflows and changed the customisation function. There is obviously a lot of duplication so perhaps you have a better solution?
Also, I wasn't sure if some of the older workflows could be replaced, so played it safe and added new ones.

@vandreev11, @pfs, @lgray, @sethzenz, @kpedro88

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add workflows to reconstruct HGCal using PandoraPFA

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

please test

(new workflows aren't in the test but I might as well check I haven't messed up the others)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link
Author

For the record, workflows 15600 and 15800 run all 3 steps fine. I'll wait until after #8008 is merged though because there could be a conflict (easier for me to change this PR than fix conflicts in #8008).

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Mar 2, 2015
Add workflows to reconstruct HGCal using PandoraPFA
@cmsbuild cmsbuild merged commit 243b4db into cms-sw:CMSSW_6_2_X_SLHC Mar 2, 2015
@mark-grimes mark-grimes deleted the addPandoraWorkflow branch March 3, 2015 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants