Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some more printouts from RECO step #8010

Merged
merged 3 commits into from Mar 5, 2015

Conversation

davidlange6
Copy link
Contributor

Some notes:

-- I'm not sure why CMS has two copies of ObjectViewCleaner. They seem identical, presumably the one in Validation/RecoTau should be removed
-- The beam spot fitter change reflects that if "improve" is called and does not find a new minimum, it returns status=4 (which is then turned into status=4000 by the time the exit of TH1F::Fit is called

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2015

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

Remove some more printouts from RECO step

It involves the following packages:

CalibFormats/SiStripObjects
CommonTools/Statistics
DQM/SiPixelMonitorRawData
PhysicsTools/TagAndProbe
RecoVertex/BeamSpotProducer
SLHCUpgradeSimulations/Configuration
Validation/RecoTau

@civanch, @diguida, @cvuosalo, @mdhildreth, @monttj, @cmsbuild, @nclopezo, @cerminar, @deguio, @slava77, @vadler, @mmusich, @danduggan can you please review it and eventually sign? Thanks.
@appeltel, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @threus, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2015

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Mar 5, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants