New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getByToken, not getByLabel, in EcalTrigPrimProducer #8014
Use getByToken, not getByLabel, in EcalTrigPrimProducer #8014
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Use getByToken, not getByLabel, in EcalTrigPrimProducer It involves the following packages: SimCalorimetry/EcalTrigPrimProducers @cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Use getByToken, not getByLabel, in EcalTrigPrimProducer
The consumes interface was added to EcalTrigPrimProducer recently. This PR completes the migration by replacing the getByLabel calls with getByToken.